Better: Prepend .gitconfig with random hash to allow concurrency #9219
Conversation
|
This is an interesting change. I implemented a similar change in my internal fork and I faced the same challenge. Interestedly enough, it only seems to apply to some ecosystems. Maven for example, does not have this problem |
|
@JamieMagee Can you take a look at this one |
|
I can confirm that we have seen this with npm and go. Example error:
|
|
@abdulapopoola Could you please help us find a reviewer for this change? |
|
HI @yeikel , we have started working on the request, ill get back to you in case required. thanks ! |
|
Hi @ylecuyer , @yeikel , I went through the changes. Thanks a lot for your contribution! Do you have high confidence w.r.t any unknowns. Alternatively, I am proposing adding changes behind a feature flag and monitor for some time before finally adding to code base. Let me know if you are good with this. |
That would work. I don't have any concerns with that approach |
|
@ylecuyer , thanks! , ill try to finish it by today. |
sachin-sandhu
force-pushed
the
allow-concurrency-gitconfig-yle
branch
from
d3e9399 to
7a2d512
Compare
sachin-sandhu
force-pushed
the
allow-concurrency-gitconfig-yle
branch
from
7a2d512 to
dc28861
Compare
|
(I didn't go with feature flag as i think this was not needed) I monitored the release for few hours to see if any exceptions are coming up. Didn't observe any unintended behaviour. We will monitor it for few days to see everything is good. Thanks a lot @ylecuyer for your contributions. |
Hello,
I followed the advice here https://github.com/dependabot/dependabot-script/blob/main/update-script.rb#L32 and went with looping all dependencies. I also went a bit further and added https://github.com/grosser/parallel with an each in process to speed up the handling of dependencies.
But I faced the issue that all processes try to update the same .gitconfig file at the same time which is locked.
The fix I propose here is to prepend the .gitconfig file name with a random hash to avoid conflicts